feature/projects #39
Merged
feature/projects #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeppekroghitk
changed the base branch from
develop
to
feature/sprint-planning
jeppekroghitk
force-pushed
the
feature/projects
branch
from
256d7c2 to
9f694c9
Compare
tuj
requested changes
Jan 16, 2024
src/Entity/PriceList.php
Outdated
| @@ -0,0 +1,40 @@ | |||
| <?php | |||
There was a problem hiding this comment.
What is the purpose of the PriceList? It is not used anywhere else in the system.
There was a problem hiding this comment.
Atm. it does not have any purpose in the system and should be removed.
tuj
requested changes
Jan 16, 2024
jeppekroghitk
force-pushed
the
feature/projects
branch
from
750c012 to
51cde69
Compare
tuj
reviewed
Jan 17, 2024
src/Form/ClientType.php
Outdated
| 'required' => true, | ||
| 'row_attr' => ['class' => 'form-element-wrapper'], | ||
| ]) | ||
| ->add('standardPrice', TextType::class, [ |
There was a problem hiding this comment.
This should be a NumberType: https://symfony.com/doc/current/reference/forms/types/number.html
src/Form/ClientType.php
Outdated
| ], | ||
| 'attr' => [ | ||
| 'class' => 'form-element', | ||
| 'data-create-project-target' => 'choice', |
Adjustments to feature/projects
Feature/projects sync adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/tickets/showKanban#/tickets/showTicket/463
Description
Implements sync of projects, issues, worklogs etc from Leantime.
Checklist